The first two are acked. See below for comment on this one.

On 2014-06-17 01:02, Peter Meerwald wrote:
not tested

Signed-off-by: Peter Meerwald <[email protected]>
---
  src/pulsecore/protocol-native.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/src/pulsecore/protocol-native.c b/src/pulsecore/protocol-native.c
index 589013b..dc0665d 100644
--- a/src/pulsecore/protocol-native.c
+++ b/src/pulsecore/protocol-native.c
@@ -2592,6 +2592,8 @@ static void setup_srbchannel(pa_native_connection *c) {
      pa_tagstruct *t;
      int fdlist[2];

+    pa_proplist_setf(c->client->proplist, "native-protocol.srbchannel", "%s", 
pa_yes_no(false));

Isn't pa_yes_no translated? I think it would make more sense to do "true"/"false" for things you put in proplists.

Otherwise acked, if you test it.

+
      if (!c->options->srbchannel) {
          pa_log_debug("Disabling srbchannel, reason: Disabled by module 
parameter");
          return;
@@ -2641,6 +2643,7 @@ static void command_enable_srbchannel(pa_pdispatch *pd, 
uint32_t command, uint32

      pa_log_debug("Client enabled srbchannel.");
      pa_pstream_set_srbchannel(c->pstream, c->srpending);
+    pa_proplist_setf(c->client->proplist, "native-protocol.srbchannel", "%s", 
pa_yes_no(true));
      c->srpending = NULL;
  }

@@ -2757,6 +2760,7 @@ static void command_auth(pa_pdispatch *pd, uint32_t 
command, uint32_t tag, pa_ta

      pa_log_debug("Negotiated SHM: %s", pa_yes_no(do_shm));
      pa_pstream_enable_shm(c->pstream, do_shm);
+    pa_proplist_setf(c->client->proplist, "native-protocol.shm", "%s", 
pa_yes_no(do_shm));

      reply = reply_new(tag);
      pa_tagstruct_putu32(reply, PA_PROTOCOL_VERSION | (do_shm ? 0x80000000 : 
0));


--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
_______________________________________________
pulseaudio-discuss mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Reply via email to