Hi Sajeesh,
Thanks for trying to contribute to PulseAudio. While going through old
patches I found this one, but as Pierre-Louis says below, I'm not sure
how this would reduce power consumption.
Could you explain? Or we could drop your patch in case you changed your
mind.
Thanks,
On 2014-08-05 23:59, Pierre-Louis Bossart wrote:
On 8/5/14, 12:35 AM, Sajeesh Sidharthan wrote:
---
src/modules/bluetooth/module-bluez5-device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/modules/bluetooth/module-bluez5-device.c
b/src/modules/bluetooth/module-bluez5-device.c
index 57b2791..eda7a9d 100644
--- a/src/modules/bluetooth/module-bluez5-device.c
+++ b/src/modules/bluetooth/module-bluez5-device.c
@@ -1170,10 +1170,10 @@ static void thread_func(void *userdata) {
a2dp_reduce_bitpool(u);
}
}
-
- do_write = 1;
- pending_read_bytes = 0;
}
+
+ do_write = 1;
+ pending_read_bytes = 0;
}
if (writable && do_write > 0) {
@@ -1208,7 +1208,7 @@ static void thread_func(void *userdata) {
sleep_for = PA_USEC_PER_MSEC * 500;
pa_rtpoll_set_timer_relative(u->rtpoll, sleep_for);
- disable_timer = false;
+ /* disable_timer = false; *//* Disable timer to
reduce power consumption */
Why would this reduce power consumption, one would think that you want
to buffer up by specifying a large latency. If you disable timers you'll
have to force a specific buffer size for this sink.
Thanks,
-Pierre
_______________________________________________
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
_______________________________________________
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
