On 31 December 2015 at 11:16, Tanu Kaskinen <[email protected]> wrote: > On Thu, 2015-12-31 at 09:42 +0530, [email protected] wrote: >> From: Arun Raghavan <[email protected]> >> >> We should do stricter validation when we can. >> --- >> src/pulse/format.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/src/pulse/format.c b/src/pulse/format.c >> index c2a1552..b07940a 100644 >> --- a/src/pulse/format.c >> +++ b/src/pulse/format.c >> @@ -101,7 +101,13 @@ void pa_format_info_free(pa_format_info *f) { >> } >> >> int pa_format_info_valid(const pa_format_info *f) { >> - return (f->encoding >= 0 && f->encoding < PA_ENCODING_MAX && f->plist >> != NULL); >> + pa_sample_spec ss; >> + >> + if (pa_format_info_is_pcm(f)) { >> + pa_format_info_to_sample_spec(f, &ss, NULL); >> + return pa_sample_spec_valid(&ss); >> + } else >> + return (f->encoding >= 0 && f->encoding < PA_ENCODING_MAX && >> f->plist != NULL); >> } >> >> int pa_format_info_is_pcm(const pa_format_info *f) { > > Looks good to me, and this seems appropriate for 8.0 too.
As usual, my preference is to be super-conservative during the freeze so we can go from RC to final as quickly as possible. -- Arun _______________________________________________ pulseaudio-discuss mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
