On 11.03.2016 09:46, Tanu Kaskinen wrote:
On Thu, 2015-03-26 at 21:54 +0100, Georg Chini wrote:
+static const char *is_trigger_stream(struct userdata *u, pa_sink_input *i) {
I'd expect a function named "is_foo" to return a boolean value. It
looks confusing to me to have assignments like "role =
is_trigger_stream()". If the function returns some additional
information, I think it would be better to do that with a return
parameter. I can make a separate patch for this, though, so I'll push
this patch as is.
I fixed this in one of the later patches and renamed the function to
get_trigger_role.
_______________________________________________
pulseaudio-discuss mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
