On 12.04.2016 06:33, Arun Raghavan wrote:
On Thu, 2016-04-07 at 09:15 +0200, Georg Chini wrote:
BTW, do you think the debug output of module-loopback is
better now?
Yes, although if it's logged twice a second, it might be better
to
print the status only if explicitly requested via a module
argument.

The status is printed once every adjust time and only when debug
logging is enabled. 500ms seems to be a good value for the adjust
time, it is currently my default. If you prefer an additional
argument
to enable logging, I can add it.
Yes, I'd prefer that. Continous logging annoys me when it's about
something that I'm not currently interested in. module-loopback
isn't
the only thing generating annoying logs, but decreasing the
interval
from 10 seconds to 0.5 seconds makes the problem that much worse.

Would it be OK to add a log-interval argument with a default of
let's say 5 seconds or would you prefer if there is no logging
at all without an argument?
My preference is to not add modargs for trivial things like this. Pick
a value that is sensible for users and reduce that locally while
debugging if needed.


Two maintainers, two opinions. Which recommendation should I follow?
_______________________________________________
pulseaudio-discuss mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Reply via email to