On 25.10.2016 15:02, Tanu Kaskinen wrote:
This adds a new "use_default_sink" field to pa_sink_input. If
use_default_sink is set, the stream will be automatically moved when the
default sink changes. Usually if the user changes the default sink, the
user also wants to move existing streams there. If a stream is manually
routed, use_default_sink isn't set, so automatic moving doesn't happen
in that case.

pa_sink_input_move_to() and other move functions take use_default_sink
as a parameter so that every call site is forced to make a conscious
decision whether the stream should stick to the move target or not.

There are FIXME items added for some corner cases, because it's not
currently possible to properly remember and prioritize the various
automatic routing decisions that modules do. The different routing
modules tend to step on each other's toes, and this new
"use_default_sink" feature adds to the problem.

The same changes are made for source outputs too.

BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=93006
---

I don't understand why you need that flag at all. Why not simply
take all streams that are on the old default sink and move them
to the new default sink?
It's really weired that streams that are currently not on the default
sink should jump to the new default sink if the default changes.
From a user perspective I would not expect that (and personally
would not want to have it that way).

Regards
             Georg
_______________________________________________
pulseaudio-discuss mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Reply via email to