On Thu, 2018-04-12 at 11:31 +0200, Tomaž Šolc wrote:
> On 10. 04. 2018 14:26, Tanu Kaskinen wrote:
> > > I removed this default because the new webrtc configuration class seems
> > > to define some sensible defaults itself. Individual components no longer
> > > need to be explicitly enabled/disabled like before.
> > >
> > > I think upstream has a much better knowledge of which defaults make
> > > sense. For example, high pass filter is disabled by default in the
> > > current upstream (while DEFAULT_HIGH_PASS_FILTER was set to true).
> > Shouldn't we then remove all the other defaults as well?
> The upstream code is in the middle of migration between two
> configuration systems:
> Some settings use the new webrtc::AudioProcessing::Config class. That
> class includes some defaults that have been defined upstream. I made
> module-echo-cancel respect those defaults (high_pass_filter,
> Other settings still use the old webrtc::Config class. That class has no
> defaults. Hence I left in place the old DEFAULT_... macros.
Ok, sounds reasonable.
pulseaudio-discuss mailing list