Current code does not check whether pa_play_file call failed. Hence no error is
reported in the cli interface if playback failed because e.g. file isn't
readable by the daemon.
---
src/pulsecore/cli-command.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/pulsecore/cli-command.c b/src/pulsecore/cli-command.c
index 44795b0d..db09e5dc 100644
--- a/src/pulsecore/cli-command.c
+++ b/src/pulsecore/cli-command.c
@@ -1282,7 +1282,12 @@ static int pa_cli_command_play_file(pa_core *c,
pa_tokenizer *t, pa_strbuf *buf,
return -1;
}
- return pa_play_file(sink, fname, NULL);
+ if (pa_play_file(sink, fname, NULL)) {
+ pa_strbuf_puts(buf, "Failed to play sound file.\n");
+ return -1;
+ }
+
+ return 0;
}
static int pa_cli_command_list_shared_props(pa_core *c, pa_tokenizer *t,
pa_strbuf *buf, bool *fail) {
--
2.11.0
_______________________________________________
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
