Jira (PUP-6025) Windows GetFileAttributes calls fail / symlink? may return false for a valid symlink

Title: Message Title

Glenn Sarti commented on

PUP-6025

Change #1

Modified symlink? in lib/puppet/util/windows/file.rb

  def symlink?(file_name)

      attributes = get_attributes(file_name, false)

      if (attributes == INVALID_FILE_ATTRIBUTES )

        false

      else

        (attributes & FILE_ATTRIBUTE_REPARSE_POINT) == FILE_ATTRIBUTE_REPARSE_POINT

end

end

Modified get_attributes in lib/puppet/util/windows.rb

  def get_attributes(file_name, raise_on_error = true)

    result = GetFileAttributesW(wide_string(file_name.to_s))

    return result unless raise_on_error

    return result unless result == INVALID_FILE_ATTRIBUTES

    raise Puppet::Util::Windows::Error.new("GetFileAttributes(#{file_name})")

end

Results

Count    : 15

Average  : 19029.5333333333

Sum      : 285443

Maximum  : 19330

Minimum  : 18573

About 500ms faster on average. An improvement, but not significant.

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Reply via email to