Issue #4020 has been updated by Brian Gallew.

File nagios_maker.rb.diff added

I have attached a new diff for Naginator.  This will make Naginator do the 
right thing when it comes to properties that can be arrays (e.g. use, members), 
and fixes the problem with the previous patch whereby the config files were 
pretty much always re-written.

This is not a *perfect* fix in that it does not have any logic to distinguish 
between properties that should be arrays, and properties that should not.  
Doing that would require a larger change where the parameters list would have 
to be built from two different lists, one for array-legal properties, and one 
for normal properties.  Personally, I don't think this is a huge issue, though 
if that's what would be required to get approved, I'll do it.
----------------------------------------
Feature #4020: metaparameter "hostgroups" in nagios_host type should accept 
arrays
http://projects.puppetlabs.com/issues/4020

Author: Gabriel Filion
Status: Ready for Checkin
Priority: Normal
Assignee: Markus Roberts
Category: 
Target version: 
Keywords: 
Branch: 


When supplying an array of strings to the hostgroups value of nagios_host 
resources, the strings should be joined by commas.

currently, doing so:

    nagios_host{ "foo.bar":
    address => "foo.bar",
    hostgroups => ["hello", "world"],
}

results in something like the following:

    define host {
    address      foo.bar
    host_name    foo.bar
    hostgroups   hello
}

It should instead read:

    define host {
    address      foo.bar
    host_name    foo.bar
    hostgroups   hello,world
}



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to