Jira (FACT-2956) Facter should ensure core facts are resolved before loading custom facts

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper updated an issue   Facter / FACT-2956 Facter should ensure core facts are resolved before loading custom facts Change By: Josh Cooper Facter 4 calls {{Kernel.load}} on all custom ruby facts before core facts have been resolved. If the custom ruby facts has code outside a {{setcode}} block, then it's possible for core facts like {{Facter.value(:operatingsystem)}} to return nil, like FACT-2880. It is true that custom facts shouldn't misbehave that way, but a single misbehaving custom fact can prevent PE from managing itself. We also don't have tooling/validation to warn or prevent users from doing this, so there are many examples of it in practice. We should be more defensive about this. One way would be to ensure core facts are resolved before custom facts are loaded. It would still be possible for a custom fact with a higher weight to override the core fact, but at least the core fact would never have a nil value. Facter 3 didn't have this issue because core facts were implemented in C++ and evaluated before loading custom ruby facts. Due to this issue, puppet may not be able to manage services, because puppet selects {{base}} as the default service provider instead of {{systemd}}: {noformat} change from 'stopped' to 'running' failed: Services must specify a start command or a binary (corrective) {noformat} Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.389854.1614799263000.157948.1614894600046%40Atlassian.JIRA.