Jira (FACT-2956) Facter should ensure core facts are resolved before loading custom facts

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper commented on FACT-2956   Re: Facter should ensure core facts are resolved before loading custom facts I think the issue Kevin and Charlie are concerned about is actually fixed in FACT-2937. The problem isn't that core facts aren't available when the custom fact is evaluated. It's that the init provider uses a legacy fact to confine its suitability and facter was filtering out the custom fact, even when requested via Facter.value. This is true for both facter -p and puppet facts show: [root@jerky-luxury ~]# puppet --version 7.4.1 [root@jerky-luxury ~]# cat /opt/puppetlabs/puppet/cache/lib/facter/boom.rb require 'puppet' Puppet::Type.type(:service).new(:name => 'something') [root@jerky-luxury ~]# facter -p | head -1 [2021-03-06 00:19:30.893599 ] ERROR Facter - error while resolving custom facts in /opt/puppetlabs/puppet/cache/lib/facter/boom.rb Could not autoload puppet/type/service: Could not autoload puppet/provider/service/bsd: Could not autoload puppet/provider/service/init: undefined method `downcase' for nil:NilClass aio_agent_version => 7.4.1 # puppet facts show | head -1 Error: Could not autoload puppet/provider/service/init: undefined method `downcase' for nil:NilClass Error: Could not autoload puppet/provider/service/bsd: Could not autoload puppet/provider/service/init: undefined method `downcase' for nil:NilClass Error: Could not autoload puppet/type/service: Could not autoload puppet/provider/service/bsd: Could not autoload puppet/provider/service/init: undefined method `downcase' for nil:NilClass Error: Facter: error while resolving custom facts in /opt/puppetlabs/puppet/cache/lib/facter/boom.rb Could not autoload puppet/type/service: Could not autoload puppet/provider/service/bsd: Could not autoload puppet/provider/service/init: undefined method `downcase' for nil:NilClass I can eliminate the issue doing any of the following: explicitly asking for legacy facts [root@jerky-luxury ~]# facter -p --show-legacy | head -1 aio_agent_version => 7.4.1 using facter#main $ bx facter -p | head -1 [2021-03-05 16:21:29.017042 ] ERROR Facter - error while resolving custom facts in /Users/josh/.puppetlabs/opt/puppet/cache/lib/facter/bad.rb Could not autoload puppet/type/service: Could not autoload puppet/provider/service/launchd: undefined method `downcase' for nil:NilClass aio_agent_version => 5.5.21 $ FACTER_LOCATION=file:///Users/josh/work/facter bundle exec facter -p | head -1 aio_agent_version => 5.5.21 changing the init confine logic to use a structured fact instead os = Facter.value('os.name').downcase family = Facter.value('os.family').downcase So I think this ticket is an issue, but it's not the issue we were thinking. Let's chat Monday to discuss Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.389854.1614799263000.158987.1614990360101%40Atlassian.JIRA.