Issue #7290 has been updated by Daniel Pittman.
Pieter van de Bruggen wrote: > CloudPack currently depends on being able to pass unrecognized keys through > options, not only as a convenience for action composition, but as a way of > passing process state across action boundaries (you know, without actually > introducing _state_). I will confess, that smells pretty bad to me. If we need state, we should actually have state. If we don't, we shouldn't. Supporting arbitrary extra data being passed around and, presumably, mutated by other methods by side-effect seems risky: it would be easy enough for a seemingly unrelated change to break your state management and cause disaster, I expect... ---------------------------------------- Refactor #7290: Faces should fail hard if unknown options are passed to them... https://projects.puppetlabs.com/issues/7290 Author: Daniel Pittman Status: Needs Decision Priority: Normal Assignee: Nigel Kersten Category: Faces Target version: 2.7.1 Affected Puppet version: 2.7.0rc1 Keywords: Branch: At the moment faces quietly ignore unknown keys in the `options` hash, or during invocation. This is probably not a safe long term strategy, as it invites the typo fairy to really mess up your code in subtle and hard to debug ways. However, solving it requires that we deal with the whole `puppet/defaults.rb` set of options vs face options vs global face options, etc, etc, and is a behavioural change I am not entirely comfortable with in the RC series. We should make a final call, one way or another, and impose the right behaviour before we get to the 2.7.1 release, I think. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
