Issue #7290 has been updated by Daniel Pittman.
After further offline discussion with Pieter, it looks like this is basically a case where we might need to pass mutable state, but it isn't actually that it passes through the options unmodified. Alternatives exist including: * avoid the mutable state entirely in the code, by returning more data * pass mutable state as an option value, using a regular rich Ruby type * ditto, except as a positional argument, not a named argument The current use, which is about error handling behaviour, needs some attention in the long term anyway; it probably wouldn't work quite right outside a CLI context. So, before this can be done we absolutely need to make sure we understand and support CloudPack (and any other users of similar constructs), but the overall goal of better argument handling seems to stand at this point. ---------------------------------------- Refactor #7290: Faces should fail hard if unknown options are passed to them... https://projects.puppetlabs.com/issues/7290 Author: Daniel Pittman Status: Needs Decision Priority: Normal Assignee: Nigel Kersten Category: Faces Target version: 2.7.1 Affected Puppet version: 2.7.0rc1 Keywords: Branch: At the moment faces quietly ignore unknown keys in the `options` hash, or during invocation. This is probably not a safe long term strategy, as it invites the typo fairy to really mess up your code in subtle and hard to debug ways. However, solving it requires that we deal with the whole `puppet/defaults.rb` set of options vs face options vs global face options, etc, etc, and is a behavioural change I am not entirely comfortable with in the RC series. We should make a final call, one way or another, and impose the right behaviour before we get to the 2.7.1 release, I think. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
