Issue #7688 has been updated by Daniel Pittman.
This is great: we absolutely need something like this in core, and this is a great implementation of the solution, I think. Trevor has done a wonderful job getting this working and into our hands. A quick review says that there are a few changes that would be valuable as we integrate that; this is hardly exhaustive, only indicative: * needs tests * one function should be strictly internal, not exposed to the language * one function is actually a configuration values, once in core * the target / namevar bit needs more study; I think the current structure is more or less required, but it means an extra layer of indirection between the name of the target file and any dependencies in user manifests * `parent_build` makes me worry that we are introducing strong grouping semantics through a back-channel; it might be redundant to just depending on the other file, or it might be deeper than that * needs some documentation polish. (eg: in the :unique param, the comment about sort precedence is not clear to me.) * the `order` property kind of scares me. I am really, really not sure what the semantics are, or should be, or why. Especially if you don't specify a glob, but rather a subset of files, or an array of globs, or... * `order` seems to kind of trick our logic about building the file, rather than delegating insync or whatever * the fragment stuff also seems to trick our sync logic All in all, I think this needs a bit of polish, especially around questions of usability, but is a great place to start from, and will be a big boon to our users to get into the core. ---------------------------------------- Feature #7688: Review and potentially merge Onyx Point Concat module https://projects.puppetlabs.com/issues/7688 Author: James Turnbull Status: Needs Decision Priority: Normal Assignee: Nigel Kersten Category: plug-ins Target version: Telly Affected Puppet version: Keywords: Branch: https://github.com/onyxpoint/pupmod-concat Puppet Concat Module - This is a module that provides a native type for performing multi-part file concatenation, generally referred to by the Puppet Labs team as the File Fragment Pattern. https://github.com/onyxpoint/pupmod-concat -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
