Issue #7837 has been updated by Daniel Pittman.
> Subject changed from secret_agent return a report, which is unnecessary. to > secret_agent returns a report, which is unnecessary. I don't think this is actually so: rather than returning nothing, it would be better to use a rendering hook to inspect the report object, then produce content that was aimed at human consumption when asked to render for :console. This has the advantage that you give good feedback on the CLI, as well as enabling access to the raw report data for people who want to consume it. (eg: output the report as JSON after the call, so someone can inspect that directly on the client machine.) Generally, if it is an Action on a Face it should absolutely return a rich, interesting Ruby object. If you want to output something simpler, do that in a rendering hook. ---------------------------------------- Bug #7837: secret_agent returns a report, which is unnecessary. https://projects.puppetlabs.com/issues/7837 Author: Nick Fagerlund Status: Accepted Priority: Normal Assignee: Category: Target version: Affected Puppet version: Keywords: Branch: When we fixed #7632, we should have taken out secret\_agent's `return report` statement and replaced it with `return ''` -- reason being, we now end up with a report object spat to the command line. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
