Issue #8419 has been reported by Matt Pascoe.

----------------------------------------
Bug #8419: Filters with invalid syntax do not fail, possible unintentional 
execution in environment.
https://projects.puppetlabs.com/issues/8419

Author: Matt Pascoe
Status: Unreviewed
Priority: Normal
Assignee: 
Category: 
Target version: 
Keywords: 
Branch: 
Affected mCollective version: 


When using --with-fact (and possibly other filter options), if you give it 
invalid syntax it will basically ignore the filter and go ahead and process 
everything in the default collective context.  If you give it something with 
valid syntax but something that will never match, it of course does as expected 
and returns nothing.  It should fail without proceeding if you pass --with-fact 
that is not syntactically correct, thus avoiding the possibility of 
unintentional execution in your environment.


box: ~ $ mco puppetd status --with-fact random garbage here

* [ ============================================================> ] 7 / 7

a513-dev.example.net                   Enabled, not running, last run 141 
seconds ago
a210-dev.example.net                   Enabled, not running, last run 127 
seconds ago
a610-dev.example.net                   Enabled, not running, last run 124 
seconds ago
a512-dev.example.net                   Enabled, not running, last run 119 
seconds ago


Finished processing 7 / 7 hosts in 75.75 ms
3:39



box: ~ $ mco puppetd status --with-fact randomfact=foobar

No request sent, we did not discover any nodes.


Finished processing 0 / 0 hosts in 0.00 ms


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to