Issue #8419 has been updated by R.I. Pienaar. Status changed from Accepted to Closed
3 files changed, 9 insertions(+), 2 deletions(-) http://bit.ly/oeMdee ---------------------------------------- Bug #8419: Filters with invalid syntax do not fail, possible unintentional execution in environment. https://projects.puppetlabs.com/issues/8419 Author: Matt Pascoe Status: Closed Priority: Normal Assignee: R.I. Pienaar Category: Core Target version: 1.3.x Keywords: Branch: ripienaar/bug/master/8419 Affected mCollective version: When using --with-fact (and possibly other filter options), if you give it invalid syntax it will basically ignore the filter and go ahead and process everything in the default collective context. If you give it something with valid syntax but something that will never match, it of course does as expected and returns nothing. It should fail without proceeding if you pass --with-fact that is not syntactically correct, thus avoiding the possibility of unintentional execution in your environment. <pre> box: ~ $ mco puppetd status --with-fact random garbage here * [ ============================================================> ] 7 / 7 a513-dev.example.net Enabled, not running, last run 141 seconds ago a210-dev.example.net Enabled, not running, last run 127 seconds ago a610-dev.example.net Enabled, not running, last run 124 seconds ago a512-dev.example.net Enabled, not running, last run 119 seconds ago Finished processing 7 / 7 hosts in 75.75 ms 3:39 </pre> <pre> box: ~ $ mco puppetd status --with-fact randomfact=foobar No request sent, we did not discover any nodes. Finished processing 0 / 0 hosts in 0.00 ms </pre> -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
