Issue #8955 has been updated by R.I. Pienaar.
Few small comments on the agent: * We should change the license in the metadata to ASL2 I guess * The version should be bumped? maybe to something in line with PE version * You serialize the hash into pson generally this isnt needed as MC will do serialization too, but I guess you need it to retain the puppet type hints and so it has to be pson? * Should move the puppetral.rb and .ddl to a subdir called 'agent' to make it consistent with other agents and to help with eventual packaging ---------------------------------------- Bug #8955: Finish and merge puppetral refactor in https://projects.puppetlabs.com/issues/8955 Author: Matt Robinson Status: Accepted Priority: Normal Assignee: Max Martin Category: Target version: Keywords: Branch: https://github.com/MaxMartin/mcollective-plugins/tree/puppetral Affected mCollective version: In order to do most of the dashboard/mcollective/puppet integration the puppetral agent needs to be able to do more. Currently it can only create, not find or search. There's already a branch where most of this work has been done (see branch field), it just needs a few more tests and we should probably ask RI to review it before merging. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
