Issue #7934 has been updated by Jacob Helwig. Status changed from Accepted to In Topic Branch Pending Merge Branch set to https://github.com/jhelwig/puppet-dashboard/tree/ticket/1.2rc/7934-hide-file-bucket-link-for-new-files
I've got a branch that implements what I understand to be the minimal fix, though I'm not really happy with it. The change in [my branch on GitHub](https://github.com/jhelwig/puppet-dashboard/tree/ticket/1.2rc/7934-hide-file-bucket-link-for-new-files) removes the link in all cases, except where the report shows that the file contents were changed. As I mention in the commit message, this will hide the link in a number of cases where the file contents are actually available. (#7934) Only link old file checksum to file bucket when contents have changed The file bucket is only populated with the old contents of a file, when the file is changed by Puppet. Since the new contents of the file are not put into the file bucket, the links that were shown for the new file contents would only work if there was a file previously had that particular checksum. Now, we only make the checksum a link to view the contents from the file bucket if the checksum is for the old file contents, and do not show the link for the new file contents, or if the file was created in that puppet run. This does mean that we are hiding the link in cases where there is a chance that the file contents could actually be shown. For example, if we are looking at an old report where a file was created, but the contents were changed in later Puppet runs. Are we absolutely sure this is the interim step we wish to take, or am I completely misunderstanding what the minimal fix was intended to be? ---------------------------------------- Bug #7934: Dashboard shouldn't link to the current file in the filebucket, as it won't be available. https://projects.puppetlabs.com/issues/7934 Author: Peter Meier Status: In Topic Branch Pending Merge Priority: High Assignee: Category: Target version: 1.x Keywords: Branch: https://github.com/jhelwig/puppet-dashboard/tree/ticket/1.2rc/7934-hide-file-bucket-link-for-new-files Affected URL: Affected Dashboard version: Within the report for each file-content-md5sum dashboard is showing a link to retrieve the content from the filebucket. However, as puppet is (imho) only uploading the old (changed) file to the filebucket, you are never able to view the latest (currently active) file. You also get a ups something went wrong screen on that link, which is not that nice -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
