Issue #7934 has been updated by Nigel Kersten.

I think that is the right minimal fix Jacob, but feel free to poke holes in my 
reasoning in case I'm missing something.

In the majority of cases, the new file contents will not be available in the 
filebucket. The only times when they will be, will be if there has been churn 
in state, like A -> B -> A, or if file contents are shared across multiple 
resources, and we get the same effective result in the bucket.

This does mean we're losing some valid links, but it seems significantly worse 
to automatically link when we know in most cases the new file content won't be 
available. 

Your description is right, but I think it's actually a pretty minimal chance 
that the new content will be available somewhere in the filebucket.


Longer term we should resolve this, but it's probably best done with static 
catalogs, where the new file content *is* actually delivered in the form of a 
filebucket and we handle synchronization separately or something _waves hands_


----------------------------------------
Bug #7934: Dashboard shouldn't link to the current file in the filebucket, as 
it won't be available.
https://projects.puppetlabs.com/issues/7934

Author: Peter Meier
Status: In Topic Branch Pending Merge
Priority: High
Assignee: 
Category: 
Target version: 1.x
Keywords: 
Branch: 
https://github.com/jhelwig/puppet-dashboard/tree/ticket/1.2rc/7934-hide-file-bucket-link-for-new-files
Affected URL: 
Affected Dashboard version: 


Within the report for each file-content-md5sum dashboard is showing a link to 
retrieve the content from the filebucket. However, as puppet is (imho) only 
uploading the old (changed) file to the filebucket, you are never able to view 
the latest (currently active) file.

You also get a ups something went wrong screen on that link, which is not that 
nice


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to