Issue #2344 has been updated by Matthaus Litteken.

Status changed from Accepted to In Topic Branch Pending Merge

Fixed in commit 
https://github.com/haus/facter/commit/88f343cb26fca2cab1983ccc2eddb9993248e8b2

Branch: virtual_vmware_fix

Repo: [email protected]:haus/facter.git

Pull Request: https://github.com/puppetlabs/facter/pull/48
----------------------------------------
Bug #2344: VMware workstation detected as vmware_server
https://projects.puppetlabs.com/issues/2344

Author: Joe McDonagh
Status: In Topic Branch Pending Merge
Priority: Normal
Assignee: Paul Nasrat
Category: library
Target version: 1.6.x
Keywords: vmware
Branch: 
Affected Facter version: 


The test that detects vmware_server is pretty unintelligent; it just checks the 
location of a file. The proper way to do it would probably be vmware -v | awk 
'{ print $1"_"$2 }' | tr [:upper:] [:lower:]. That'll get you a nice 
vmware_server or vmware_workstation. I have this patch at home but I didn't 
submit it since the diff deals with other issues as well.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to