Issue #7621 has been updated by William Van Hevelingen.
> * Do we need a new fact for 'windowsrelease'? Can you tell me what value this > might add? I don't have a strong reason, but its seems that using xp or 7 is easier than remembering kernel versions. Although, If I get some help we might be able to make it a regex instead of comparing to constants. I got stuck on the how to account for "2008 R2" > * If there is value in windowsrelease ... creating a new mswindows.rb util is > unnecessary. Its only used for getting the release. Why don't you just do > that work in your 'windowsrelease' fact, and re-use the fact information in > operatingsystem.rb? will do > * can you take a look at the recent changes to kernelrelease.rb and see if > you can use the way we now do WMI queries as well? yes > Other then that - once we get a version can you rebase and submit a pull > request via git on that branch please? Sorry to be a hassle - its just easier > for us :-). And since you're doing it in github anyway I presume its easier > for you as well :-). yes > > I'm going to mark this 'Code Insufficient' for now - but don't get the wrong > idea ... the code is pretty good its just the organisation I'm commenting on > here :-). And since we recently did a Windows sprint some items have changed > a tad. Thanks Ken! Also I might be around puppetlabs on friday if you want to chat. ---------------------------------------- Feature #7621: Windows operatingsystemrelease support https://projects.puppetlabs.com/issues/7621 Author: William Van Hevelingen Status: Code Insufficient Priority: Normal Assignee: William Van Hevelingen Category: library Target version: 1.7.0 Keywords: windows Branch: https://github.com/blkperl/facter/tree/feature/master/7621-windows_osrelease Affected Facter version: 1.6.2rc1 operatingsystemrelease should return any of the following XP, Vista, 7, 2003, 2008, 2008R2 rather than the kernel version. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
