Issue #7621 has been updated by William Van Hevelingen.
Ken Barber wrote: > So my comment about 'windowsrelease' just be clear was more around me being > dumb and wondering why it is separate from 'operatingsystemrelease' in your > patch. What do you get from windowsrelease? Do you have sample output? oh windowsrelease is the caption returned by wmi and operatingsystemrelease is just the "7" from that caption. If I finish the tests for #7643 and it gets merged then windowsrelease would be duplicated because it also returns caption. Maybe I should remove it from this commit. <pre> C:\Users\blkperl>WMIC OS GET CAPTION Microsoft Windows 7 Professional C:\Users\blkperl>WMIC OS GET CAPTION Microsoft Windows Server 2008 R2 Enterprise </pre> ---------------------------------------- Feature #7621: Windows operatingsystemrelease support https://projects.puppetlabs.com/issues/7621 Author: William Van Hevelingen Status: Code Insufficient Priority: Normal Assignee: William Van Hevelingen Category: library Target version: 1.7.0 Keywords: windows Branch: https://github.com/blkperl/facter/tree/feature/master/7621-windows_osrelease Affected Facter version: 1.6.2rc1 operatingsystemrelease should return any of the following XP, Vista, 7, 2003, 2008, 2008R2 rather than the kernel version. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
