Issue #8011 has been updated by Dominic Cleal. Branch changed from https://github.com/domcleal/puppet/tree/tickets/master/8011 to https://github.com/domcleal/puppet/tree/tickets/master/8011b
Jacob Helwig wrote: > I've reverted the merge into `master`. > [Jenkins](https://jenkins.puppetlabs.com) revealed a problem with the code > when > running the tests against Ruby 1.9. > > Doing '`resource[:source].map ...`' doesn't appear to be doing what was > assumed. It works with Ruby 1.8.7 since String#map will iterate over the > lines > in the string, but this was removed in Ruby 1.9. The source parameter isn't > coming in as an array. Given what it looks like the intent of the provider > code is there, I don't think that this is actually the right way to go about > it. It looks like we should either update all of the providers to handle > source being an array instead of just a string, or say that only one source is > supported for this provider and stop trying to iterate over it. Interesting, glad you caught that. Only allowing one source would be OK, but I've also updated the patch to use a fix from another provider, allowing both a string and array - tested now on both 1.8.7 and 1.9.1. Is that acceptable? ---------------------------------------- Feature #8011: Support temp repo URL in pkgutil provider https://projects.puppetlabs.com/issues/8011 Author: Dominic Cleal Status: Code Insufficient Priority: Normal Assignee: Dominic Cleal Category: package Target version: Telly Affected Puppet version: Keywords: pkgutil solaris Branch: https://github.com/domcleal/puppet/tree/tickets/master/8011b The pkgutil provider should support using the "source" attribute of the package type as a temporary repo URL, then supply it to pkgutil with the -t option. Other providers such as gem, pip, openbsd, freebsd and ports support this usage already. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
