Issue #8011 has been updated by Dominic Cleal.
Jacob Helwig wrote: > Splitting the string on newlines (default input record separator) doesn't > seem unreasonable, just a little awkward. > > The only real problem that I think is left is that I don't think the '`if > source.is_a?(String)`' will ever be anything other than true. Pretty sure > that the source parameter definition would need to be changed to something > like > newparam(:source, :array_matching => :all) do > ... > end > in order for '`resource[:source]`' to ever be an array, and if it were > changed to be that then I think would always be an array (when used in an > actual manifest). I'm more than happy to be proven wrong here, though. I've tried changing it, but the unit test immediately began to fail as it passed an array to test multiple sources. This made me wonder if users of the Ruby DSL would be passing in arrays, rather than a newline-delimited string? Admittedly I hadn't thought about this before now, having just copied it from the augeas provider where the "changes" attribute works either with a string or array in the Puppet DSL. I suspect it's there because of the unit test issue above. I suggest we leave it supporting both? > Also, this change to the source parameter definition is what I was talking > about being hesitant to do earlier. Yes, I understand now and don't think the type should change. For most providers there's no mechanism to pass multiple URLs, but in this case I think does make sense to support it if we can. ---------------------------------------- Feature #8011: Support temp repo URL in pkgutil provider https://projects.puppetlabs.com/issues/8011 Author: Dominic Cleal Status: Code Insufficient Priority: Normal Assignee: Dominic Cleal Category: package Target version: Telly Affected Puppet version: Keywords: pkgutil solaris Branch: https://github.com/domcleal/puppet/tree/tickets/master/8011b The pkgutil provider should support using the "source" attribute of the package type as a temporary repo URL, then supply it to pkgutil with the -t option. Other providers such as gem, pip, openbsd, freebsd and ports support this usage already. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
