Issue #10238 has been updated by Adrien Thebo.

This is actually a pretty cool fact, and I can see the utility. However, the 
concern that I have is that all the actual evaluation of the block devices 
happens outside of the setcode blocks, which means that this will only be 
evaluated at load time. If someone were to hot swap a hard drive and facter was 
running in a long running ruby process, it would not pick up the change. I'll 
run this by a dev and see what they think, but again, this would definitely be 
good to have inside facter.
----------------------------------------
Feature #10238: Add support for identifying block devices to Facter
https://projects.puppetlabs.com/issues/10238

Author: Jason Gill
Status: Needs Decision
Priority: Low
Assignee: Adrien Thebo
Category: library
Target version: 
Keywords: 
Branch: 
Affected Facter version: 


I've written a simple fact for Facter which parses /sys/block/ on Linux to 
identify block devices attached to the machine. This fact is serving as a good 
base for a hardware RAID querying fact that I'm working on, so I hoped to get 
it added to a future release of Facter. Additionally, users of the Puppet 
Inventory Service could find this quite handy for identifying the disks 
attached to machines (we have hundreds of servers with a large number of 
different disks and we're trying to identify machines that have older or slower 
drives still in use).

You can find my code [over at 
github](https://github.com/jasongill/facter-factpack/blob/master/blockdevice.rb)

Example output from a machine with 2x Dell PowerEdge RAID Controller arrays and 
a CD drive:
    blockdevice_sda => DELL PERC H700
    blockdevice_sdb => DELL PERC H700
    blockdevice_sr0 => TEAC DVD-ROM DV-28SW
    blockdevices => sda,sdb,sr0    

Example output from a machine with two Western Digital SATA disks:
    blockdevice_sda => ATA WDC WD5000AAKS-0
    blockdevice_sdb => ATA WDC WD5000AAKS-0
    blockdevices => sda,sdb
    
I'm open to feedback (or please close this if I'm out of line suggesting a new 
fact that I wrote) - this is my first real Ruby work!


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to