Issue #10238 has been updated by Ken Barber.
Jason Gill wrote: > Ken I totally agree, having the size and other details (like SCSI LUN, etc) > would be really great. However in this initial version I just went with what > was most important to me - the names of the devices (sda sdb sdc) and the > make/model (which has been really handy to find which machines have what type > of drives, locate old drives, etc, with puppet inventory service). Lol. The driving force behind most facter submissions :-). We have the problem of trying to please everyone though :-). > That being said, adding even more facts probably isn't the solution - on some > of my boxes that have 500+ IP's up on them, it takes facter about 20 seconds > to run and generate all ~1600 facts that come "out of the box" with 1.6.2. Sounds like you need caching really :-). This particular fact you've written to read files is very light. > Would it be better to just add more in to the existing blockdevice_sda fact > (like a comma separated list of values or some other ugliness)? Possible - do you have a proposed format? > Or is it possible that a future version of facter could support this sort of > "advanced" fact in a hash style or similar? Yes - but in the future. There is a ticket about it somewhere. ---------------------------------------- Feature #10238: Add support for identifying block devices to Facter https://projects.puppetlabs.com/issues/10238 Author: Jason Gill Status: Tests Insufficient Priority: Low Assignee: Adrien Thebo Category: library Target version: Keywords: Branch: Affected Facter version: I've written a simple fact for Facter which parses /sys/block/ on Linux to identify block devices attached to the machine. This fact is serving as a good base for a hardware RAID querying fact that I'm working on, so I hoped to get it added to a future release of Facter. Additionally, users of the Puppet Inventory Service could find this quite handy for identifying the disks attached to machines (we have hundreds of servers with a large number of different disks and we're trying to identify machines that have older or slower drives still in use). You can find my code [over at github](https://github.com/jasongill/facter-factpack/blob/master/blockdevice.rb) Example output from a machine with 2x Dell PowerEdge RAID Controller arrays and a CD drive: blockdevice_sda => DELL PERC H700 blockdevice_sdb => DELL PERC H700 blockdevice_sr0 => TEAC DVD-ROM DV-28SW blockdevices => sda,sdb,sr0 Example output from a machine with two Western Digital SATA disks: blockdevice_sda => ATA WDC WD5000AAKS-0 blockdevice_sdb => ATA WDC WD5000AAKS-0 blockdevices => sda,sdb I'm open to feedback (or please close this if I'm out of line suggesting a new fact that I wrote) - this is my first real Ruby work! -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
