Issue #3323 has been updated by Daniel Pittman.
James Turnbull wrote: > Daniel - I'd welcome some help refactoring this then. So, my first question is: is there actually value in this change? Given that `hasrestart => true, restart => '... graceful'` has the same effect, is it worth adding extra code to make this happen? Second question, do we want to add more restart modes at this point in time, rather than delaying until we have richer semantics available for notifications. (eg: restart gracefully for these notifications, but full restart for these others, type stuff.) Assuming the answer is yes to both, I would suggest the API be the option to set `graceful` for `hasrestart`, which has the effect of invoking the init script with `graceful` rather than `restart` as the option. That seems the minimum change, adds no new fields, and almost no new semantics. Does that seem reasonable? It feels like the absolute minimum change to support flagging this is a service we would prefer to restart one way rather than another, without having to explicitly spell out that invocation in the `restart` property. ---------------------------------------- Feature #3323: Create hasreload similar to hasrestart https://projects.puppetlabs.com/issues/3323 Author: Chuck McIntyre Status: Code Insufficient Priority: Normal Assignee: Chuck McIntyre Category: service Target version: Telly Affected Puppet version: 0.24.8 Keywords: hasreload, service Branch: https://github.com/jamtur01/puppet/tree/tickets/master/3323 Many init scripts allow for a "reload" option in addition to a restart and a stop/start. It would be useful if this could be defined for a given service generically, rather than having to resort to an Exec resource or other workaround for cases where we want to reload instead of restart (an example could be made using apache or bind configuration changes). I am attaching an example diff (note this is not a patch, nor has it been tested) to describe in more detail how this might be accomplished. I am willing to submit a patch for this if the feature is accepted. I would like some guidance as to whether the existing unit test modifications are sufficient or if it is necessary to test that (at least) reload and restart get called appropriately (not simply that stop/start get called when not specified). -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
