Issue #11612 has been updated by Ken Barber. Status changed from In Topic Branch Pending Review to Tests Insufficient Target version set to 1.6.x
Hi Hongbo, This looks good, but we are lacking rspec tests on the code. Do you think you can add these? In lieu of that - attaching the output of all the various commands you use in your code to this ticket would help someone write suitable tests. Alternatively you can put them in spec/fixtures/unit/<suitable_area> (ie. spec/fixtures/unit/hardwaremodel/ for hardware model rspec) in your git repo. * model * /bin/netstat -in * ioscan -fknCprocessor * Any others? ---------------------------------------- Feature #11612: add facter support for ia 11.31 hpux processor discover and a bug fix for network interface https://projects.puppetlabs.com/issues/11612 Author: hongbo hu Status: Tests Insufficient Priority: Normal Assignee: Category: library Target version: 1.6.x Keywords: facter hpux Branch: https://github.com/puppetlabs/facter/pull/127 Affected Facter version: 1.6.4 1. add cpu information support to facter support HPUX 11.31 IA64 2. when server has mc-sg the network card has standby lan card marked with '*' ,when run faster ,it'll show ifconfig no such interface error pull requre at github https://github.com/puppetlabs/facter/pull/127 I'll add more feature for hp and aix -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
