Issue #8341 has been updated by Matt Robinson.
Patrick and I were looking at this and came up with this quick patch (in attached branch) that seems to fix the issue - but it hasn't been tested or thoroughly researched to look for side effects. All the specs pass, but I haven't run the acceptance tests yet or done much manual testing besides a quick puppet run with nothing interesting in the manifest. It basically boils down to not calling Puppet::Node::Facts::Facter.load_fact_plugins twice in two adjacent lines (indirectly on one line), and using require instead of load. This does have implications on order, but so did load and I'm not sure it was a conscious decision about what order to load things in. ---------------------------------------- Bug #8341: Loading facts repeatedly https://projects.puppetlabs.com/issues/8341 Author: Trevor Vaughan Status: Needs More Information Priority: Normal Assignee: Daniel Pittman Category: facter Target version: 2.7.10 Affected Puppet version: Keywords: custom fact, repeated Branch: https://github.com/adrienthebo/puppet/tree/ticket/2.7.x/8341-prevent_duplicate_loading_of_facts Puppet seems to be getting overzealous when loading custom facts. Example: <pre> Loading facts in custom_fact_1 Loading facts in custom_fact_2 Loading facts in custom_fact_3 Loading facts in custom_fact_5 Loading facts in custom_fact_7 Loading facts in custom_fact_8 Loading facts in custom_fact_9 Loading facts in custom_fact_10 Loading facts in custom_fact_11 Loading facts in custom_fact_12 Loading facts in custom_fact_13 Loading facts in custom_fact_14 Loading facts in custom_fact_5 Loading facts in custom_fact_7 Loading facts in custom_fact_2 Loading facts in custom_fact_3 Loading facts in custom_fact_12 Loading facts in custom_fact_11 Loading facts in custom_fact_10 Loading facts in custom_fact_8 Loading facts in custom_fact_13 Loading facts in custom_fact_6 Loading facts in custom_fact_14 Loading facts in custom_fact_9 Loading facts in custom_fact_1 Loading facts in custom_fact_1 Loading facts in custom_fact_2 Loading facts in custom_fact_3 Loading facts in custom_fact_5 Loading facts in custom_fact_6 Loading facts in custom_fact_7 Loading facts in custom_fact_8 Loading facts in custom_fact_9 Loading facts in custom_fact_10 Loading facts in custom_fact_11 Loading facts in custom_fact_12 Loading facts in custom_fact_13 Loading facts in custom_fact_14 Loading facts in custom_fact_5 Loading facts in custom_fact_7 Loading facts in custom_fact_2 Loading facts in custom_fact_3 Loading facts in custom_fact_12 Loading facts in custom_fact_11 Loading facts in custom_fact_10 Loading facts in custom_fact_8 Loading facts in custom_fact_13 Loading facts in custom_fact_6 Loading facts in custom_fact_14 Loading facts in custom_fact_9 Loading facts in custom_fact_1 </pre> -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
