Issue #8341 has been updated by Matt Robinson. Assignee changed from Daniel Pittman to Patrick Carlisle
Yes, that's the branch, thanks for updating. I'm not entirely sure that require is right either, but it does make the multiple loads go away if you have the same fact in multiple places (modulepath, factspath, libdir). I think those directories that can contain facts should have some precedence order, and we should log when a plugin is either loaded multiple times or not loaded because it already has been from a different location. Also, I don't think that the require vs load in lib/puppet/indirector/facts/facter.rb affects pluginsync since it has it's method to load plugins after being synced lib/puppet/configurer/plugin_handler.rb:29. I think more significant is fixing the multiple loading when you DON'T have a fact in multiple places, which is the the removal of the reload_facter call in the fact_handler. I'm assigning this to Patrick since he was working with me on this yesterday and I have to get back to other code. ---------------------------------------- Bug #8341: Loading facts repeatedly https://projects.puppetlabs.com/issues/8341 Author: Trevor Vaughan Status: Needs More Information Priority: Normal Assignee: Patrick Carlisle Category: facter Target version: 2.7.10 Affected Puppet version: Keywords: custom fact, repeated Branch: https://github.com/adrienthebo/puppet/tree/ticket/2.7.x/8341-prevent_duplicate_loading_of_facts Puppet seems to be getting overzealous when loading custom facts. Example: <pre> Loading facts in custom_fact_1 Loading facts in custom_fact_2 Loading facts in custom_fact_3 Loading facts in custom_fact_5 Loading facts in custom_fact_7 Loading facts in custom_fact_8 Loading facts in custom_fact_9 Loading facts in custom_fact_10 Loading facts in custom_fact_11 Loading facts in custom_fact_12 Loading facts in custom_fact_13 Loading facts in custom_fact_14 Loading facts in custom_fact_5 Loading facts in custom_fact_7 Loading facts in custom_fact_2 Loading facts in custom_fact_3 Loading facts in custom_fact_12 Loading facts in custom_fact_11 Loading facts in custom_fact_10 Loading facts in custom_fact_8 Loading facts in custom_fact_13 Loading facts in custom_fact_6 Loading facts in custom_fact_14 Loading facts in custom_fact_9 Loading facts in custom_fact_1 Loading facts in custom_fact_1 Loading facts in custom_fact_2 Loading facts in custom_fact_3 Loading facts in custom_fact_5 Loading facts in custom_fact_6 Loading facts in custom_fact_7 Loading facts in custom_fact_8 Loading facts in custom_fact_9 Loading facts in custom_fact_10 Loading facts in custom_fact_11 Loading facts in custom_fact_12 Loading facts in custom_fact_13 Loading facts in custom_fact_14 Loading facts in custom_fact_5 Loading facts in custom_fact_7 Loading facts in custom_fact_2 Loading facts in custom_fact_3 Loading facts in custom_fact_12 Loading facts in custom_fact_11 Loading facts in custom_fact_10 Loading facts in custom_fact_8 Loading facts in custom_fact_13 Loading facts in custom_fact_6 Loading facts in custom_fact_14 Loading facts in custom_fact_9 Loading facts in custom_fact_1 </pre> -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
