Issue #11566 has been updated by Josh Cooper. Status changed from In Topic Branch Pending Review to Merged - Pending Release Assignee set to Ken Barber
This was merged in <https://github.com/puppetlabs/facter/commit/184224a01b40a04848c3432367e22ee8391b74ca>: <pre> (#11566) Add windows support for ec2 facts This patch adds support for detecting ec2 on windows. This works by modifying the linux methodology by using arp -a instead of arp -an and searching for the mac address with a hyphen delimiter (as apposed to a quote). I've added tests and a sample fixtures which adds output from arp -a from a windows machine and linux machines, on ec2 and not on ec2. I've also re-worked the decision making into a util class so the testing is much easier to write and work with, so now we can test the individual mechanism for detecting that we are in a cloud on their own. This will be much better abstracted into their own fact(s) but for now this has the least impact to solve the problem at hand. In the future this logic (and tests) can certainly be re-used if such a fact was evercreated. Thanks to Feifei Jia <[email protected]> for contributing the original code. </pre> ---------------------------------------- Feature #11566: Windows EC2 meta data support https://projects.puppetlabs.com/issues/11566 Author: Feifei Jia Status: Merged - Pending Release Priority: Immediate Assignee: Ken Barber Category: library Target version: 1.6.5 Keywords: Branch: https://github.com/puppetlabs/facter/pull/140 Affected Facter version: Hi, I sent a pull request to support this feature, the link is here: https://github.com/puppetlabs/facter/pull/125 Any feedback welcomed, thanks. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
