Issue #12844 has been updated by Chris Price.
Notes: This started occurring with commit b434e3b9c31de63365e1a0f53d152be7e6e988ec, which was first released in 2.7.10. This change introduced the ability to distinguish between a "normal" lockfile (which indicates that an agent run is currently in progress, filename "puppetdlock") and a "disabled" lockfile (which indicates that we've administratively disabled the agent, filename "puppetdlock.disabled"). If a user runs "agent --disable" in an old version, the "puppetdlock" gets created. Then they upgrade, and the new version expects the "disabled" lock to be named "puppetdlock.disabled"; thus, "agent --enable" doesn't do anything. The main problem here is that the old filename still has a valid meaning with the new code; it theoretically means that there is an agent process currently running. Thus, putting in some code to try to delete this file (in the interest of maintaining backwards compatibility) is not a good solution unless there is a way that I can tell which of the two meanings the file had. Patrick says that there may be contents written into the file in the case where it's representing a currently running agent, and it may be empty in the case where it's just there because of a "--disable". I'm investigating this now. ---------------------------------------- Bug #12844: Puppet upgrade can't remove lockfile. https://projects.puppetlabs.com/issues/12844#change-55873 Author: Trevor Vaughan Status: Accepted Priority: High Assignee: Chris Price Category: Target version: Affected Puppet version: 2.7.11 Keywords: lock file, puppet agent, disable, enable Branch: Procedure: Start with 2.7.7 Run puppet agent --disable Upgrade to 2.7.11 Run puppet agent --enable Result: puppet agent --enable does not remove /var/lib/puppet/state/puppetdlock and puppet will no longer run. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
