Issue #12844 has been updated by Chris Price.
It looks like the previous versions of the code do indeed write a pid to this file in the "agent is currently running" case, and leaves the file empty in the "administratively disabled" case. So, during the "agent --enable" run, we could theoretically read the file and if there is no pid in it we could assume that it's from an old version of puppet and delete it. Other options would be: * change the code so that the "normal agent is running" filename is different, which would allow us to easily distinguish files generated by older versions of puppet... but this sounds risky because Daniel says that nagios (and perhaps mcollective) stuff are checking for this file by a specific name. * back out the offending commit from 2.7.x and apply it to master, and then possibly implement the filename change there because we have more flexibility to break things. ---------------------------------------- Bug #12844: Puppet upgrade can't remove lockfile. https://projects.puppetlabs.com/issues/12844#change-55875 Author: Trevor Vaughan Status: Accepted Priority: High Assignee: Chris Price Category: Target version: 2.7.12 Affected Puppet version: 2.7.11 Keywords: lock file, puppet agent, disable, enable Branch: Procedure: Start with 2.7.7 Run puppet agent --disable Upgrade to 2.7.11 Run puppet agent --enable Result: puppet agent --enable does not remove /var/lib/puppet/state/puppetdlock and puppet will no longer run. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
