Issue #4836 has been updated by Chris Price. Status changed from Accepted to Closed Keywords changed from enabledisable to enable disable
I introduced some confusion when describing this ticket to Haus; I had some of the details of this ticket mixed up with ticket #11057. There are 2 requests in this ticket: 1. better error message when agent is administratively disabled, 2. user-definable error message. These were both addressed in pull request 216, which has now been reverted from 2.7.12 (see #12844). However, the first of those two behaviors can be accomplished without changing the lockfile semantics, and when I discussed this with Haus he stated that he would like to see that go into 2.7.12. The second of those two behaviors does require a change to the lockfile semantics, so it'll be put on hold until 3.x. In hopes of making this a bit less confusing, I'm going to close this ticket out and open two new ones targeted at different versions. ---------------------------------------- Feature #4836: puppetd --disable improvements https://projects.puppetlabs.com/issues/4836#change-56101 Author: micah - Status: Closed Priority: Low Assignee: Chris Price Category: error reporting Target version: Telly Affected Puppet version: 0.25.5 Keywords: enable disable Branch: https://github.com/puppetlabs/puppet/pull/216 Occasionally I disable regular puppetd runs on a system by doing: <pre> # puppetd --disable </pre> This works fine, except that it could be improved in two ways: 1. If it has been manually disabled, then when a run is attempted, it should print something more useful than this: <pre> notice: Run of Puppet configuration client already in progress; skipping </pre> because well... that message isn't really true, its not in progress, rather it is currently disabled. 2. The something more useful that it could print could be either a default message "notice: Puppet administratively disabled on this system; skipping", or a custom message that you can pass to the puppetd --disable, eg. "puppetd --disable micah is fixing stunnel template" would then print the following when a puppetd was running: "notice: Puppet is administratively disabled because micah is fixing stunnel template; skipping run" -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
