Issue #16728 has been updated by eric sorenson.

Talked a bit with Pieter today. There are two areas at issue:

1. there is no code which actually does tty vs non-tty detection and 
re-prepends the notice log levels to the output depending on the device.
2. the messages which should output a prepended level regardless of output 
channel (because 'notice' should only be used for those messages whose prefixes 
would be stripped when headed to a TTY) need to be shifted to use other log 
levels.

A simple revert would break those parts of the system (faces such as `puppet 
module`) which have already shifted to emit unprefixed output.
----------------------------------------
Bug #16728: puppet agent --verbose has lost notice tag
https://projects.puppetlabs.com/issues/16728#change-75703

Author: Malcolm Howe
Status: Needs Decision
Priority: Normal
Assignee: eric sorenson
Category: agent
Target version: 
Affected Puppet version: 3.0.0
Keywords: ux
Branch: 


In puppet 2.7 lines output from puppet agent --verbose start with a level tag 
such as debug, notice, info, warning, err with the exception of lines that 
could be considered as continuation lines. In puppet 3.0 these have become 
capitalized (Debug, Info etc) and the range of the colouring has changed which 
are fine but notice has disappeared. Example:

Puppet 2.7

    ^[[0;37mdebug: /File[/usr/local/admin/etc/cronjobs]/content: Executing 
'diff /usr/local/admin/etc/cronjobs 
/tmp/puppet-file20121003-21437-1039k7-0'^[[0m
    ^[[0;36mnotice: /File[/usr/local/admin/etc/cronjobs]/content:
    394c394
    < On OX_HFS_DD At 07:31
    ---
    > On OX_HFS_DD At 07:30
    ^[[0m
    ^[[0;36mnotice: /File[/usr/local/admin/etc/cronjobs]/content: content 
changed '{md5}bab2e7212b6dbf31a4aa24d80af20dff' to 
'{md5}7a959b40ab3403d747fe953c1855343d'^[[0m

puppet 3.0.0

    ^[[0;36mDebug^[[0m: Executing 'diff /usr/local/admin/etc/cronjobs 
/tmp/puppet-file20121003-18288-1q7segx-0'
    /File[/usr/local/admin/etc/cronjobs]/content:
    394c394
    < On OX_HFS_DD At 07:31
    ---
    > On OX_HFS_DD At 07:30
    /File[/usr/local/admin/etc/cronjobs]/content: content changed 
'{md5}d89edc6045aa721fba77ec0f54c8c2d2' to 
'{md5}101441e8bf893cce06ccb87983626b8b'


This is a nuisance when trying to analyse the output with a script.

I am, of course, assuming it isn't an intentional change. If not I'm reporting 
it as a bug.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to