Issue #17794 has been updated by Marc Fournier.
I don't seem to have sufficient permission in redmine to update status and branch information for this ticket (can someone with privileges correct this BTW ? I can do this sort of thing for puppet bugs). In any case, here's my suggestion for this bug: https://github.com/puppetlabs/facter/pull/358 Even if it isn't the "right" way to do the job, I think the updated specfiles describe what I've described in this bugreport. If you run the new code with the old tests, the only failures you should have are the 2 "should not run on Linux" tests. ---------------------------------------- Bug #17794: zpool_version and zfs_version should not be restricted to only sun and bsd https://projects.puppetlabs.com/issues/17794#change-77421 Author: Marc Fournier Status: Unreviewed Priority: Normal Assignee: Category: library Target version: 1.7.0 Keywords: zfs_version zpool_version Branch: Affected Facter version: development #13047 and #13049 added support for a couple more platforms to `$::zpool_version` and `$::zfs_version`. But nowadays, ZFS runs on more or less every unix platform. So it seems better to confine on the availability of the `zpool` and `zfs` commands in the `$PATH`, instead of maintaining a list of supported operating systems. This is exactly what has been done a couple of months ago to the zfs/zpool providers in puppet. Have a look at #9416 and https://github.com/puppetlabs/puppet/pull/1011 for the details. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
