Issue #17794 has been updated by Jeff McCune. Status changed from In Topic Branch Pending Review to Tests Insufficient Assignee set to Marc Fournier
# Failing tests Marc, Thanks, I notice the change is causing tests to fail though. I've updated the pull request discussion [1] with clear next actions on this. Please re-open the pull request once they're addressed, or ping me on IRC if you have any questions or concerns. [1] <https://github.com/puppetlabs/facter/pull/358> Thanks, -Jeff ---------------------------------------- Bug #17794: zpool_version and zfs_version should not be restricted to only sun and bsd https://projects.puppetlabs.com/issues/17794#change-77895 Author: Marc Fournier Status: Tests Insufficient Priority: Normal Assignee: Marc Fournier Category: library Target version: 1.7.0 Keywords: zfs_version zpool_version Branch: https://github.com/puppetlabs/facter/pull/358 Affected Facter version: development #13047 and #13049 added support for a couple more platforms to `$::zpool_version` and `$::zfs_version`. But nowadays, ZFS runs on more or less every unix platform. So it seems better to confine on the availability of the `zpool` and `zfs` commands in the `$PATH`, instead of maintaining a list of supported operating systems. This is exactly what has been done a couple of months ago to the zfs/zpool providers in puppet. Have a look at #9416 and https://github.com/puppetlabs/puppet/pull/1011 for the details. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to puppet-bugs@googlegroups.com. To unsubscribe from this group, send email to puppet-bugs+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
