Issue #17820 has been reported by Per Cederqvist.

----------------------------------------
Bug #17820: eval_generate is needlessly slow
https://projects.puppetlabs.com/issues/17820

Author: Per Cederqvist
Status: Unreviewed
Priority: Normal
Assignee: 
Category: performance
Target version: 
Affected Puppet version: 3.0.1
Keywords: 
Branch: 


By changing a single line in eval_generate in lib/puppet/transaction.rb I 
managed to speed up "puppet agent --test" from 4494 to 593 seconds. The code 
should produce the same result, but avoids allocating so many hashes.

Here is the diff.  If you prefer, I can create a Git branch et c, but I hope it 
isn't necessary for such a simple fix.

I'm also attaching the output from two ruby-prof runs, in call graph format: 
before and after the change.

(593 seconds is still too much. I suspect I might be submitting a new bug 
report in the not too distant future. :-)  Still, this change should be a 
speedup for everybody, and it shouldn't hurt anybody.)


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to