Issue #17820 has been updated by Per Cederqvist.
Josh Cooper wrote: > [...] Since Puppet 3 is not compatible with 1.8.5, I'll issue a separate pull > request for 3.0.x.[..] It isn't? I'm using the packages from http://apt.puppetlabs.com/ and they depend on "ruby". On Debian 6.0.6 (squeeze) that installs ruby 1.8.7. If Puppet 3 really requires ruby 1.9, the debian packages should require ruby1.9.1, and /usr/bin/puppet should start with "#!/usr/bin/ruby1.9.1" instead of "#!/usr/bin/ruby". Should I report that as a separate issue? Is this the appropriate bug tracker for apt.puppetlabs.com issues? I've reported issue #17855 today; the facter packaging seems to have the same issue. ---------------------------------------- Bug #17820: eval_generate is needlessly slow https://projects.puppetlabs.com/issues/17820#change-77752 Author: Per Cederqvist Status: Merged - Pending Release Priority: Normal Assignee: Category: performance Target version: 2.7.21 Affected Puppet version: 2.7.9 Keywords: Branch: https://github.com/puppetlabs/puppet/pull/1293 By changing a single line in eval_generate in lib/puppet/transaction.rb I managed to speed up "puppet agent --test" from 4494 to 593 seconds. The code should produce the same result, but avoids allocating so many hashes. Here is the diff. If you prefer, I can create a Git branch et c, but I hope it isn't necessary for such a simple fix. I'm also attaching the output from two ruby-prof runs, in call graph format: before and after the change. (593 seconds is still too much. I suspect I might be submitting a new bug report in the not too distant future. :-) Still, this change should be a speedup for everybody, and it shouldn't hurt anybody.) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
