Issue #14199 has been updated by Jeff McCune. Status changed from Needs Decision to Code Insufficient Branch set to https://github.com/puppetlabs/puppet/pull/1289
Please see the comments in the pull request at: <https://github.com/puppetlabs/puppet/pull/1289> for next actions. @kozhukalov Thanks for the pull request! Type vs Providers ----- I notice this check is in the munge block for the type. Will this cause issues when puppet agent is run on a separate node as the puppet master? That is to say, the munge block will only be executed when the compiler produces a catalog in the master, not when the agent applies the catalog, right? Code - missing examples ----- Before we merge this into Puppet examples that exercise this change in behavior need to be included in the patch. If you're not comfortable adding RSpec examples, I'm happy to help out. I'm jmccune in #puppet-dev on freenode. Please include examples that will automatically let us know if this problem resurfaces in the future, otherwise we may have a regression as we continue to make changes over time. Next Steps ---- 1. Please consider changing the provider instead of the type. 2. Please add examples that exercise this behavior. Existing spec tests should provide a good starting point. I'm going to go ahead and close this pull request for the time being. Please re-open this pull request once new information is available, or if you have any questions or concerns. Closing the pull request doesn't mean we don't consider this change valuable, just that there are things that need to be addressed before it can be merged. If you have any questions or concerns, please don't hesitate to ping us in #puppet-dev on irc.freenode.net. ---------------------------------------- Bug #14199: Mount resource don't recognize already mounted resources if there is a symlink in mountpoint path https://projects.puppetlabs.com/issues/14199#change-77527 Author: Rafał Kupka Status: Code Insufficient Priority: Normal Assignee: Category: mount Target version: 2.7.15 Affected Puppet version: Keywords: mount symlink Branch: https://github.com/puppetlabs/puppet/pull/1289 Mount command (and /proc/mounts file) only shows mountpoint path with symlinks resolved. Puppet don't recognize this resources as already mounted. More information: #grep /sl /etc/fstab /dev/sda9 /srv/sl xfs rw 0 0 # ls -l /srv/sl lrwxrwxrwx 1 root root 5 Apr 26 14:07 /srv/sl -> video # mount | grep video /dev/sda9 on /srv/video type xfs (...) # puppet apply --noop -e 'mount { "/srv/sl": ensure => mounted; }' notice: /Stage[main]//Mount[/srv/sl]/ensure: current_value unmounted, should be mounted (noop) notice: /Stage[main]//Mount[/srv/sl]: Would have triggered 'refresh' from 1 events Puppet version with attached patch applied works fine. [Github patch](https://github.com/kupson/puppet/commit/487d782b7426ebc66d9e6aa44608de12eada0a49) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
