Issue #19779 has been updated by Matthaus Owens.

Released in Puppet 3.2.0-rc1

----------------------------------------
Bug #19779: Isolite pretty-print of PSON via jj
https://projects.puppetlabs.com/issues/19779#change-89577

* Author: Peter Meier
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: compiler
* Target version: 3.2.0
* Affected Puppet version: 3.1.1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1534
----------------------------------------
In #8194 pretty printing of PSON via Kernel.jj was introduced.

However, the jj Method is monkey patched into Kernel from 
`lib/puppet/external/pson/common.rb`. But this monkeypatching is for example 
also done by json_pure.

This has the disadvantage that if custom puppet code requires json_pure, 
Puppet's monkeypatching is overwritten and hence `puppet master --compile node` 
doesn't print anymore a valid catalog.

Kernel.jj is nowhere else used in the whole puppet code base, except for 
catalog printing.

Hence simply exchanging:

<pre>
jj catalog.to_resource
</pre>
with 
<pre>
puts PSON::pretty_generate(catalog.to_resource, :allow_nan => true, 
:max_nesting => false)
</pre>

in lib/puppet/application/master.rb fixes the broken output.

I don't really think it is necessary to pretty print via Kernel.jj, so a simple 
subsitution should fix that problem.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to