Issue #19805 has been updated by Matthaus Owens.

Released in Puppet 3.2.0-rc1

----------------------------------------
Bug #19805: [PATCH] Service restart failures are ignored with 
--detailed-exitcodes
https://projects.puppetlabs.com/issues/19805#change-89578

* Author: Lubomir Rintel
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: error reporting
* Target version: 3.2.0
* Affected Puppet version: 3.1.1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1541
----------------------------------------
Documentation to --detailed-exitcodes states that mask 0x4 is applied in case
"there were failures during the transaction." Currently only failures to change
resource state are reported, failures to restart the resource are still ignored.

Only change (code=2) to Exec['/bin/true'] is considered here:

  $ puppet apply --detailed-exitcodes -e 'service { "duckfaced": restart => 
"/bin/false", ensure => running, status => "/bin/true" } exec { "/bin/true": 
notify => Service["duckfaced"] }'
  $ echo $?
  2

Needless to say, information about failed restarts is usually as important to 
the user as the status changes, since they usually mean that desired
configuration is not in effect.

This change makes Puppet consider information about failed restarts when 
setting the failure bit.

Another possibility to avoid loosing the information  would be to introduce 
another bit in the exit code mask, but that would change semantics with respect
to existing documentation and thus probably be more confusing.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to