Issue #18913 has been updated by Sven Mueller. Status changed from Closed to Re-opened
rspec-puppet just worked around the issue. The fix should really happen in puppetlabs_spec_helper. The spec_helper is supposed to act as a gateway between spec tests and puppet, keeping projects like rspec-puppet from handling core puppet functions directly. The proper way to resolve this would be to: Make the spec_helper not depend on rspec-puppet by removing the parts that need rspec-puppet (and probably add them to rspec-puppet instead) and then updating rspec-puppet to use the spec_helper instead of directly accessing the innards of puppet (and to using spec_helper for this). I kind of accept when you say this is not feasible for some reason (please specify which reason though). But closing this valid request because the tool that _should_ use puppetlabs_spec_helper stopped doing so is wrong. Especially since Tim achieved this by adding some functionality from the spec_helper to rspec-puppet to avoid the dependency. Please work on this with rodjek (Tim Sharpe) to resolve this properly. Thanks. ---------------------------------------- Bug #18913: puppetlabs_spec_helper requires rspec-puppet https://projects.puppetlabs.com/issues/18913#change-89948 * Author: Russell Harrison * Status: Re-opened * Priority: High * Assignee: Charlie Sharpsteen * Category: * Target version: * Affected Puppet version: * Keywords: puppetlabs_spec_helper * Branch: ---------------------------------------- Given the focus of `puppetlabs_spec_helper` to be the integration point for external projects like `rspec-puppet` it needs to be refactored to remove the dependency on `rspec-puppet` since you can't even require `rspec-puppet` without it. Currently rodjek is [planning to refactor](https://github.com/rodjek/rspec-puppet/issues/56#issuecomment-12667834) `rspec-puppet` to no longer use `puppetlabs_spec_helper` but this seems backwards to me as he'll be forced to return to reverse engineering the internal workings of puppet which is exactly what this project is intended to solve. This prevents using either the `rspec-puppet` or `puppetlabs_spec_helper` gems until the dependency cycle is resolved. It also [prevents packaging](https://bugzilla.redhat.com/show_bug.cgi?id=787350) of either gem. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
