Issue #16635 has been updated by Adrien Thebo. Status changed from Tests Insufficient to Merged - Pending Release Assignee deleted (eric sorenson) Target version changed from 3.x to 3.3.0
Merged into master in 9a67810; this should be released in 3.3.0. ---------------------------------------- Bug #16635: pkgdmg provider doesn't honor http_proxy_host/http_proxy_port https://projects.puppetlabs.com/issues/16635#change-94128 * Author: Clay Caviness * Status: Merged - Pending Release * Priority: Normal * Assignee: * Category: OSX * Target version: 3.3.0 * Affected Puppet version: * Keywords: * Branch: https://github.com/ahpook/puppet/tree/16635-pkgdmg-proxy ---------------------------------------- The pkgdmg provider doesn't honor http_proxy_host/http_proxy_port settings. The actual file is downloaded using an exec to curl, no proxy information is passed: <pre>curl "-o", cached_source, "-C", "-", "-k", "-L", "-s", "--url", source</pre> I copied `http_proxy_env`, `http_proxy_host`, and `http_proxy_port` functions from `puppet/forge/repository.rb` and added them to `pkgdmg.rb`, and tweaked the call to curl in `pkgdmg.rb`: <pre>if http_proxy_host and not http_proxy_port curl "-o", cached_source, "-C", "-", "-k", "-L", "-s", "--url", source, "--proxy", http_proxy_host elsif http_proxy_host and http_proxy_port curl "-o", cached_source, "-C", "-", "-k", "-L", "-s", "--url", source, "--proxy", "#{http_proxy_host}:#{http_proxy_port}" else curl "-o", cached_source, "-C", "-", "-k", "-L", "-s", "--url", source end </pre> I attached my patched pkgdmg.rb. I don't really understand how the `commands :curl => "/usr/bin/curl"` and `curl 'foo', 'bar', 'baz'` stuff actually works, so there's probably a much smoother way to do this... -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
