Issue #21884 has been updated by Brice Figureau.
eric sorenson wrote: > I added Jo Rhett as a watcher as he's been the most vocal about Schedule > changes/functionality in the past. > > Jo, two questions -- does this change affect you at all? And/or can you think > of how it might affect someone else? > > Added Brice as it was his pull which caused the change. > > Brice, was this something you anticipated from your change or an 'action at a > distance' consequence, or...? > > These answers will help guide if this should cause a revert of the patch, > further work to restore previous behaviour in the reports without a revert, > or no further action. Thanks!! That was the whole point of this patch: prior to the network device stuff added back in 2.7.x, those resources weren't skipped. This latest patch restored the original behavior. So now you see those not skipped. If you really want to check that's the correct behavior, simply resurrect an old 2.7 or 2.6 (like 2.7.1 since I don't exactly remember when the network device was merged in), do a small run and check that the Schedule are not skipped. Now do the same with a 3.x (x <= 2) and check how the Schedule are skipped. Now fast forward to the latest release should show the Schedule not skipped again. Sorry for the confusion, hope this is clearer now. ---------------------------------------- Bug #21884: Schedule events status in reports has changed https://projects.puppetlabs.com/issues/21884#change-95839 * Author: Chris Price * Status: Needs More Information * Priority: Normal * Assignee: eric sorenson * Category: * Target version: * Affected Puppet version: * Keywords: * Branch: ---------------------------------------- Prior to this commit: [https://github.com/puppetlabs/puppet/commit/f51e967b73ff0154801f514aff40ca524bdd8ab1](https://github.com/puppetlabs/puppet/commit/f51e967b73ff0154801f514aff40ca524bdd8ab1) Every puppet report would include a `resource_status` for the 5-ish built-in `Schedule` events (monthly, daily, weekly, etc.), and these `resource_status` objects would be marked as `skipped`. After the referenced commit, these `resource_status` objects still show up in the report, but the value for `skipped` is now set to `false`. I am not sure what the implications of this change are, but since it's a change in behavior and didn't seem to be expected based on my initial conversations with the dev team, I thought it was worth bringing it up for further discussion / investigation. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
