Issue #22961 has been updated by Zachary Stern.

Tracker changed from Bug to Feature

----------------------------------------
Feature #22961: Detailed Exit Codes doesn't descriminate between between runs 
with failures against a master, and runs with failures using a cached catalog.
https://projects.puppetlabs.com/issues/22961#change-99105

* Author: Zachary Stern
* Status: Unreviewed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: customer
* Branch: 
----------------------------------------
Failed run against master:

        [root@pe-28-master ~]# puppet agent --onetime --no-daemonize --verbose 
--detailed-exitcodes
        info: Retrieving plugin
        info: Loading facts in 
/opt/puppet/share/puppet/modules/stdlib/lib/facter/pe_version.rb
        info: Loading facts in 
/opt/puppet/share/puppet/modules/stdlib/lib/facter/facter_dot_d.rb
        info: Loading facts in 
/opt/puppet/share/puppet/modules/stdlib/lib/facter/puppet_vardir.rb
        info: Loading facts in 
/opt/puppet/share/puppet/modules/stdlib/lib/facter/root_home.rb
        info: Loading facts in 
/opt/puppet/share/puppet/modules/auth_conf/lib/facter/custom_auth_conf.rb
        info: Loading facts in 
/opt/puppet/share/puppet/modules/concat/lib/facter/concat_basedir.rb
        info: Loading facts in /var/opt/lib/pe-puppet/lib/facter/pe_version.rb
        info: Loading facts in 
/var/opt/lib/pe-puppet/lib/facter/custom_auth_conf.rb
        info: Loading facts in 
/var/opt/lib/pe-puppet/lib/facter/concat_basedir.rb
        info: Loading facts in /var/opt/lib/pe-puppet/lib/facter/facter_dot_d.rb
        info: Loading facts in 
/var/opt/lib/pe-puppet/lib/facter/puppet_vardir.rb
        info: Loading facts in /var/opt/lib/pe-puppet/lib/facter/root_home.rb
        info: Caching catalog for pe-28-master.puppetdebug.vlan
        info: Applying configuration version '1382564343'
        err: /Stage[main]//File[/tmp/foo/bar/baz]/ensure: change from absent to 
present failed: Could not set 'present on ensure: Not a directory - 
/tmp/foo/bar/baz at /etc/puppetlabs/puppet/manifests/site.pp:47
        notice: Finished catalog run in 3.33 seconds
        
        [root@pe-28-master ~]# echo $?
        4

Failed run with cached catalog:

        [root@pe-28-master ~]# /etc/init.d/pe-httpd stop
        Stopping pe-httpd:                                         [  OK  ]
        
        [root@pe-28-master ~]# puppet agent --onetime --no-daemonize --verbose 
--detailed-exitcodes
        info: Retrieving plugin
        err: /File[/var/opt/lib/pe-puppet/lib]: Failed to generate additional 
resources using 'eval_generate: Connection refused - connect(2)
        err: /File[/var/opt/lib/pe-puppet/lib]: Could not evaluate: Connection 
refused - connect(2) Could not retrieve file metadata for 
puppet://pe-28-master.puppetd
        ebug.vlan/plugins: Connection refused - connect(2)
        info: Loading facts in 
/opt/puppet/share/puppet/modules/stdlib/lib/facter/pe_version.rb
        info: Loading facts in 
/opt/puppet/share/puppet/modules/stdlib/lib/facter/facter_dot_d.rb
        info: Loading facts in 
/opt/puppet/share/puppet/modules/stdlib/lib/facter/puppet_vardir.rb
        info: Loading facts in 
/opt/puppet/share/puppet/modules/stdlib/lib/facter/root_home.rb
        info: Loading facts in 
/opt/puppet/share/puppet/modules/auth_conf/lib/facter/custom_auth_conf.rb
        info: Loading facts in 
/opt/puppet/share/puppet/modules/concat/lib/facter/concat_basedir.rb
        info: Loading facts in /var/opt/lib/pe-puppet/lib/facter/pe_version.rb
        info: Loading facts in 
/var/opt/lib/pe-puppet/lib/facter/custom_auth_conf.rb
        info: Loading facts in 
/var/opt/lib/pe-puppet/lib/facter/concat_basedir.rb
        info: Loading facts in /var/opt/lib/pe-puppet/lib/facter/facter_dot_d.rb
        info: Loading facts in 
/var/opt/lib/pe-puppet/lib/facter/puppet_vardir.rb
        info: Loading facts in /var/opt/lib/pe-puppet/lib/facter/root_home.rb
        err: Could not retrieve catalog from remote server: Connection refused 
- connect(2)
        notice: Using cached catalog
        info: Applying configuration version '1382564343'
        err: /Stage[main]//File[/tmp/foo/bar/baz]/ensure: change from absent to 
present failed: Could not set 'present on ensure: Not a directory - 
/tmp/foo/bar/baz a
        t /etc/puppetlabs/puppet/manifests/site.pp:47
        err: 
/Stage[main]/Pe_mcollective::Server::Plugins/File[/opt/puppet/libexec/mcollectiv
        ###misc other errors (truncated)###
        notice: /Stage[main]/Pe_mcollective::Server/Service[pe-mcollective]: 
Dependency 
File[/opt/puppet/libexec/mcollective/mcollective/application/puppetd.rb] has 
failures: true
        notice: /Stage[main]/Pe_mcollective::Server/Service[pe-mcollective]: 
Dependency File[/opt/puppet/libexec/mcollective/mcollective/agent/package.ddl] 
has failures: true
        notice: /Stage[main]/Pe_mcollective::Server/Service[pe-mcollective]: 
Dependency 
File[/opt/puppet/libexec/mcollective/mcollective/util/actionpolicy.rb] has 
failures: true
        notice: /Stage[main]/Pe_mcollective::Server/Service[pe-mcollective]: 
Dependency 
File[/opt/puppet/libexec/mcollective/mcollective/agent/puppetral.ddl] has 
failures: true
        warning: /Stage[main]/Pe_mcollective::Server/Service[pe-mcollective]: 
Skipping because of failed dependencies
        notice: Finished catalog run in 2.42 seconds
        err: Could not send report: Connection refused - connect(2)
        
        [root@pe-28-master ~]# echo $?
        4
        
It would be great if it actually differentiated between the two, since they're 
very different situations.  Especially since, in PE, a cached run always has 
failures, due to the included modules.

Unable to test in PE 3.x.x since cached catalogs are currently broken there. 
Presumably the issue remains.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to