Issue #23179 has been updated by Chris Malton.

Keywords set to facter ubuntu
Affected Facter version set to 1.7.3

----------------------------------------
Bug #23179: operatingsystemmajrelease has a confine for Debian, but not Ubuntu
https://projects.puppetlabs.com/issues/23179#change-100204

* Author: Ramin K
* Status: Unreviewed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Keywords: facter ubuntu
* Branch: 
* Affected Facter version: 1.7.3
----------------------------------------
The current operatingsystemmajrelease has a listing of distros it works for. 
However Ubuntu is missing and probably other distro that should work with this 
fact. It looks like changing the code to the following would make it work in 
more cases and be easier to maintain.

<pre>
Facter.add(:operatingsystemmajrelease) do
  confine :osfamily => [
    :RedHat,
    :Debian
  ]
  setcode do
    Facter.value('operatingsystemrelease').split('.').first
  end
end

Facter.add(:operatingsystemmajrelease) do
  confine :operatingsystem => [
    :CumulusLinux
  ]
  setcode do
    Facter.value('operatingsystemrelease').split('.').first
  end
end
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to