On May 27, 2008, at 12:05 PM, Luke Kanies wrote: > - > + > private > > def model > - @model > + @model > end > - > +
As was pointed out to me, this patch contains lots of whitespace patches, which breaks one of the rules we've added (no trivial changes included in patches). I agree with this rule in principle, but... I think I would tend just not to fix this kind of problem if I had to do it as part of a different patch set. How hard and fast should this rule be? Should I redo these patches with no whitespace changes, or at least not do this again? -- Reality is that which, when you stop believing in it, doesn't go away. -- Philip K. Dick, "How to Build a Universe" --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
